Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD file.exists() #56

Merged
merged 2 commits into from
Mar 16, 2024
Merged

ADD file.exists() #56

merged 2 commits into from
Mar 16, 2024

Conversation

ninovanhooff
Copy link
Collaborator

Implemented using file.stat

@ninovanhooff ninovanhooff changed the title ADD file.exists ADD file.exists() Feb 24, 2024
@samdze
Copy link
Owner

samdze commented Mar 3, 2024

Having this simple function would be nice, but I think it would be better if it was implemented bypassing exceptions and directly using the SDK function return value.
It should be more performant.

@ninovanhooff
Copy link
Collaborator Author

Done

@samdze samdze merged commit 4e6b5d3 into samdze:main Mar 16, 2024
2 checks passed
@samdze
Copy link
Owner

samdze commented Mar 16, 2024

Nice, thanks!

@ninovanhooff ninovanhooff deleted the file_exists branch November 10, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninovanhooff @samdze